Add a command-list component #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
coorasse
commented
Aug 16, 2024
coorasse
commented
ignaciosy
approved these changes
Aug 28, 2024
Contributor
ignaciosy
left a comment
ignaciosy
left a comment
There was a problem hiding this comment.
Love the functionality!
Comment on lines
+6
to
+10
| .modal-dialog { | ||
| --bs-modal-width: 600px; | ||
| --bs-modal-margin: 5rem; | ||
| --bs-modal-padding: 1.5rem; | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think we need so much custom css here? Also doesn't look good on mobile with so much margin.
I'd also have a look at the rest of this file's classes if we really need them. (some probably yes)
Contributor
There was a problem hiding this comment.
also pretty sure there are provided classes for there, like modal-sm
|
|
||
| connect() { | ||
| this.modal = new bootstrap.Modal(this.listTarget, {}) | ||
| this.children = Array.from(this.listGroupTargets[0].children); |
Contributor
There was a problem hiding this comment.
Why not
Suggested change
| this.children = Array.from(this.listGroupTargets[0].children); | |
| this.children = Array.from(this.listGroupTarget.children); |
If it's just one target as far as I see
coorasse
force-pushed
the
command_list
branch
from
8f2b039 to
dcb2885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.