Open
Conversation
Member
|
Things that looks incorrect at first glance:
|
Member
|
I will look closer how merge-pyi works tomorrow, probably we can write our own solution that would analyze AST/tockens of the file to extract/merge the data. |
Collaborator
Author
|
Basically it's a wrapper around LibCST. You can find out more here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added scripts to generate stubs and merge them back into renpy. I updated the stubs in later commits
Couple of issues:
it'll want to do:
__init__()sets the value of a class attribute, stubgen may sometimes reset the type of that attribute to Incomplete until the__init__()typing is updated.