Open
Conversation
elektronik2k5
approved these changes
Sep 17, 2022
Comment on lines
+10
to
+22
| describeClass(Task, Entity<Task>("tasks", { | ||
| allowApiRead: Allow.authenticated, | ||
| allowApiUpdate: Allow.authenticated, | ||
| allowApiInsert: Roles.admin, | ||
| allowApiDelete: Roles.admin | ||
| }), { | ||
| id: Fields.uuid(), | ||
| title: Fields.string({ | ||
| validate: Validators.required, | ||
| allowApiUpdate: Roles.admin | ||
| }), | ||
| completed: Fields.boolean() | ||
| }) No newline at end of file |
There was a problem hiding this comment.
This looks equivalent to the decorators version. 2 questions:
- If I have a typo anywhere, does TS catch that and let me know? If no, then does at least the runtime catch it?
- Have you looked into the mobx way of decorating classes without decorators (in the ctor)? I'm assuming they carefully evaluated different approaches and that their chosen one was found superior.
Contributor
Author
There was a problem hiding this comment.
Thanks - Answers:
- Yes - typescript will let you know there is an error and search references work.
- Mobx needed something other than me - All I need is some metadata - mobx needed to alter the class instance itself - that's why they used the "makeAutoObservable" in the constructor and changed the members to properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrate how one can work without decorators with remult