fix(fetch): allow subclass methods of Headers to be called correctly#63
Open
ArnoSaine wants to merge 1 commit intoremix-run:mainfrom
Open
fix(fetch): allow subclass methods of Headers to be called correctly#63ArnoSaine wants to merge 1 commit intoremix-run:mainfrom
Headers to be called correctly#63ArnoSaine wants to merge 1 commit intoremix-run:mainfrom
Conversation
🦋 Changeset detectedLatest commit: ff5d0ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Headers to be called correctly
MichaelDeBoey
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where subclass methods of
Headerswere not being called correctly.Problem
When a class extends
Headers, the subclass's methods (likeappend) were not accessible or called properly. This was caused by theProxyinstance in theHeadersconstructor, which intercepted method calls and directed them to theURLSearchParamsprototype, bypassing any overrides defined in subclasses.Solution
Proxyfrom the constructor.Headersclass to maintain the expected behavior and allowing overrides by subclasses.Example
cc: @mjackson