feat: remove polyfills and re-exports for built-ins on node >= 18#60
Closed
leefreemanxyz wants to merge 5 commits intoremix-run:mainfrom
Closed
feat: remove polyfills and re-exports for built-ins on node >= 18#60leefreemanxyz wants to merge 5 commits intoremix-run:mainfrom
leefreemanxyz wants to merge 5 commits intoremix-run:mainfrom
Conversation
🦋 Changeset detectedLatest commit: a9914fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
leefreemanxyz
force-pushed
the
feat/remove-web-encodings-dependency
branch
from
fae12ff to
a7710bd
Compare
|
Can this be merged to resolve the issue with ReadableStream? |
MichaelDeBoey
changed the title
Member
|
I rebased @jacob-ebey's #42 onto latest Closing this one to keep all development in one place |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fresh attempt at #42. From what I can ascertain, the blob package is no longer required and doesn't need importing in other packages as it should be provided by the environment, likewise for TextEncode/TextDecoder. Readable Stream can be left as is until it is no longer experimental in Remix's supported node versions.