fix(mime): prefer video/mp4 for .mp4 and image/x-icon for .ico#11132
Merged
mjackson merged 2 commits intoremix-run:mainfrom Apr 24, 2026
Merged
fix(mime): prefer video/mp4 for .mp4 and image/x-icon for .ico#11132mjackson merged 2 commits intoremix-run:mainfrom
video/mp4 for .mp4 and image/x-icon for .ico#11132mjackson merged 2 commits intoremix-run:mainfrom
Conversation
Add preferred MIME type overrides in codegen for extensions where the algorithm picks an uncommon type: - mp4: application/mp4 → video/mp4 (RFC 4337 §2) - ico: image/vnd.microsoft.icon → image/x-icon (historical standard) Fixes remix-run#11106 Fixes remix-run#11107
MichaelDeBoey
changed the title
video/mp4 for .mp4 and image/x-icon for .ico
This was referenced Mar 31, 2026
Contributor
Author
|
Gentle ping — this fix ensures correct MIME types for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add preferred MIME type overrides in the codegen for extensions where the algorithm picks an uncommon type:
mp4:application/mp4→video/mp4per RFC 4337 §2 which specifiesvideo/mp4as the general-purpose typeico:image/vnd.microsoft.icon→image/x-iconwhich is the historically used type by Microsoft and browsersChanges
packages/mime/scripts/codegen.ts: AddpreferredOverridesmap applied after the main algorithmpackages/mime/src/generated/mime-types.ts: Updated generated outputpackages/mime/src/lib/detect-mime-type.test.ts: Updated test expectationFixes #11106
Fixes #11107