feat: currency field display consistency and constraint improvements by ManukMinasyan · Pull Request #119 · relaticle/custom-fields

ManukMinasyan · 2026-03-19T18:58:49Z

Summary

CurrencyColumn: Dedicated table column with ->numeric() formatting and $ prefix (replaces generic TextColumn)
CurrencyEntry: Dedicated infolist entry with ->numeric() formatting and $ prefix (replaces generic TextEntry)
CurrencyComponent: Removed hardcoded minValue(0), default(0), and rules(['numeric', 'min:0']) — lets the capability system (MinValueCapability, DecimalPlacesCapability) handle these. formatStateUsing and dehydrateStateUsing now handle null and respect configured decimal places.
Export transformer: Added CSV-safe export formatting (2 decimal places, no thousands separator)

Behavior changes

Surface	Before	After
Table	Raw float `1234.56`	`$1,234.56`
Infolist	Raw float `1234.56`	`$1,234.56`
Form (new record)	Pre-filled `$0.00`	Empty (null)
Form (negative values)	Blocked by hardcoded `min:0`	Allowed unless MinValueCapability configured
Form (custom decimals)	Always `100.00`	Respects config e.g. `100.000`
Export CSV	Raw float `1234.56789`	`1234.57`

Test plan

11 new tests covering CurrencyColumn, CurrencyEntry, CurrencyComponent, and export transformer (17 assertions)
Full suite: 467 tests passing
PHPStan: 0 errors
Pint: clean

…imal places

Copilot

Pull request overview

This PR improves how the currency custom field type is presented across Filament surfaces (table, infolist, form) and adds CSV-safe export formatting, aiming for consistent currency display and better alignment with the validation capability system.

Changes:

Introduces dedicated CurrencyColumn (tables) and CurrencyEntry (infolists) using numeric formatting with a $ prefix.
Updates CurrencyComponent (forms) to remove hardcoded defaults/constraints and to better handle null + configurable decimal places.
Adds an export transformer to format currency values as CSV-safe strings with fixed 2-decimal precision.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/Feature/Filament/Components/CurrencyFieldComponentsTest.php	Adds feature tests covering the new column/entry/component behavior and export transformer formatting.
src/Filament/Integration/Components/Tables/Columns/CurrencyColumn.php	New dedicated table column for currency with numeric formatting + `$` prefix.
src/Filament/Integration/Components/Infolists/CurrencyEntry.php	New dedicated infolist entry for currency with numeric formatting + `$` prefix.
src/Filament/Integration/Components/Forms/CurrencyComponent.php	Updates currency form input to respect decimal places and handle null without hardcoded min/default/rules.
src/FieldTypeSystem/Definitions/CurrencyFieldType.php	Switches currency field type to the new Filament components and adds a CSV-safe export transformer.

src/Filament/Integration/Components/Forms/CurrencyComponent.php

src/Filament/Integration/Components/Tables/Columns/CurrencyColumn.php

src/Filament/Integration/Components/Infolists/CurrencyEntry.php

src/FieldTypeSystem/Definitions/CurrencyFieldType.php

validation_rules is nullable in the database. When a custom field has null validation_rules, calling ->get() on null crashes. The nullsafe operator ?-> was incorrectly removed by a PHPStan "fix".

Replace hardcoded $ prefix and validation_rules-based decimal places with proper type-specific settings using the withSettings() API. Currency fields now have 4 configurable settings: - Currency code (50+ ISO 4217 currencies with searchable dropdown) - Display type (symbol, narrow symbol, code, name) - Decimal places (0 or 2 with live preview) - Grouping (default thousands separator or none) Display components use Filament's ->money() method instead of ->numeric()->prefix('$'). Form component derives the currency symbol dynamically via NumberFormatter. Backward compatible: getDecimalPlaces() falls back to validation_rules then default, getCurrencyCode() falls back to config default.

…selects default() doesn't reliably hydrate existing records. afterStateHydrated ensures correct values on both create and edit forms. Cast decimal_places options to strings for select component compatibility.

the visibility check wrapper was overwriting any formatStateUsing set by the column type (e.g. CurrencyColumn). now captures and re-evaluates the existing formatter when the field is visible.

apply LocallyCalledStaticMethodToNonStaticRector, EncapsedStringsToSprintfRector, and NewlineBeforeNewAssignSetRector fixes flagged by CI.

- Use CurrencyFieldSettingsData with camelCase props and MapName mapper consistent with other data classes - Hydrate settings via data class instead of raw array access - Remove dead grouping setting (collected but never consumed) - Reduce display_type to symbol/code (the two actually implemented) - Remove obsolete HRK currency (replaced by EUR in 2023) - Add 3 decimal places option for BHD/KWD/OMR currencies - Stop hardcoding 2 decimal places in import/export transformers

Copilot

Pull request overview

This PR introduces a dedicated Currency field presentation across Filament tables, infolists, and forms, and centralizes currency-related constraints (decimal places, currency code, display type) via per-field settings and validation.

Changes:

Added CurrencyColumn and CurrencyEntry using Filament money formatting for consistent display.
Updated CurrencyComponent to remove hardcoded defaults/constraints and to respect configured decimal places and null values.
Added currency settings DTO + CustomField helpers, plus currency-specific validation rules and export transformer behavior.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
tests/Feature/Filament/Components/CurrencyFieldComponentsTest.php	Adds feature coverage for currency column/entry/component/export behavior.
src/Services/ValidationService.php	Enforces currency decimal-places validation based on field settings.
src/Models/CustomField.php	Adds currency helper accessors and legacy fallback handling.
src/Filament/Integration/Components/Tables/Columns/CurrencyColumn.php	New table column for currency formatting.
src/Filament/Integration/Components/Infolists/CurrencyEntry.php	New infolist entry for currency formatting.
src/Filament/Integration/Components/Forms/CurrencyComponent.php	Updates form component formatting/dehydration and currency prefix logic.
src/Filament/Integration/Builders/TableBuilder.php	Preserves existing column formatter when applying visibility wrapper.
src/FieldTypeSystem/Definitions/CurrencyFieldType.php	Switches currency type to dedicated components and adds settings schema + import/export transformers.
src/Data/Settings/CurrencyFieldSettingsData.php	New DTO for currency-specific settings hydration.
config/custom-fields.php	Adds default currency code configuration.

Copilot · 2026-03-25T12:36:07Z

src/Filament/Integration/Components/Tables/Columns/CurrencyColumn.php

+        $column = BaseTextColumn::make($customField->getFieldName())
+            ->money(
+                $customField->getCurrencyCode(),
+                decimalPlaces: $customField->getDecimalPlaces(),


display_type (symbol vs code) is part of currency settings, but this column always uses ->money(...) which will likely render a symbol regardless. To keep display consistent across form/table/infolist, apply getCurrencyDisplayType() here (or remove the setting if it’s intended to affect forms only).

Suggested change

decimalPlaces: $customField->getDecimalPlaces(),

decimalPlaces: $customField->getDecimalPlaces(),

currencyDisplay: $customField->getCurrencyDisplayType(),

Copilot · 2026-03-25T12:36:07Z

src/FieldTypeSystem/Definitions/CurrencyFieldType.php

+            ->exportTransformer(function (mixed $value): ?string {
+                if ($value === null) {
+                    return null;
+                }
+
+                return rtrim(rtrim(number_format((float) $value, 10, '.', ''), '0'), '.');
            });


The PR description says the export transformer formats CSV values to 2 decimal places, but this transformer preserves up to 10 decimals and trims trailing zeros, and the new tests assert that behavior. Either update the transformer to match the described 2-decimal output, or update the PR description/test plan to reflect the actual export format.

Copilot · 2026-03-25T12:36:08Z

tests/Feature/Filament/Components/CurrencyFieldComponentsTest.php

+    it('creates a text column with money formatting', function (): void {
+        $field = CustomField::factory()->ofType('currency')->create();
+
+        $column = (new CurrencyColumn)->make($field);
+
+        expect($column)->toBeInstanceOf(BaseTextColumn::class);
+    });
+
+    it('uses configured currency code from settings', function (): void {
+        $field = CustomField::factory()->ofType('currency')->create([
+            'settings' => ['additional' => ['currency_code' => 'EUR', 'decimal_places' => 2]],
+        ]);
+
+        $column = (new CurrencyColumn)->make($field);
+
+        expect($column)->toBeInstanceOf(BaseTextColumn::class);
+    });


These tests only assert the returned type (BaseTextColumn / BaseTextEntry), but don’t verify the actual behavior described (money formatting, currency code, decimal places, etc.). Add assertions that the column/entry is configured with the expected formatter / currency / decimal places so regressions are caught.

Copilot · 2026-03-25T12:36:08Z

src/Filament/Integration/Components/Forms/CurrencyComponent.php

+    }
+
+    private function getCurrencySymbol(string $currencyCode, string $displayType): string
+    {


NumberFormatter requires the PHP intl extension. This component will fatally error in environments where ext-intl isn’t installed. Either add ext-intl to composer.json requirements or guard NumberFormatter usage (e.g., class_exists(NumberFormatter::class) fallback to currency code).

Suggested change

{

{

if (! class_exists(NumberFormatter::class)) {

return $currencyCode;

}

Copilot · 2026-03-25T12:36:08Z

src/Filament/Integration/Builders/TableBuilder.php

+
+                    if ($existingFormatter) {
+                        return $column->evaluate($existingFormatter, [
+                            'state' => $state,


The wrapper calls the existing formatStateUsing formatter without passing $record (or other injections). If the existing formatter expects record (common in Filament), this will break formatting. Pass at least record (and potentially column) into evaluate() so the original formatter receives the same context.

Suggested change

'state' => $state,

'state' => $state,

'record' => $record,

'column' => $column,

Copilot · 2026-03-25T12:36:09Z

src/Filament/Integration/Components/Infolists/CurrencyEntry.php

+        return BaseTextEntry::make($customField->getFieldName())
+            ->label($customField->name)
+            ->money(
+                $customField->getCurrencyCode(),
+                decimalPlaces: $customField->getDecimalPlaces(),
+            )
+            ->state(fn (mixed $record) => $record->getCustomFieldValue($customField));


display_type (symbol vs code) is configured on the field, but this entry always uses ->money(...) and doesn’t reference getCurrencyDisplayType(). Consider honoring display_type for infolist output (or removing the setting if it’s not meant to affect display here).

Suggested change

return BaseTextEntry::make($customField->getFieldName())

->label($customField->name)

->money(

$customField->getCurrencyCode(),

decimalPlaces: $customField->getDecimalPlaces(),

)

->state(fn (mixed $record) => $record->getCustomFieldValue($customField));

$entry = BaseTextEntry::make($customField->getFieldName())

->label($customField->name)

->state(fn (mixed $record) => $record->getCustomFieldValue($customField));

if ($customField->getCurrencyDisplayType() === 'symbol') {

$entry->money(

$customField->getCurrencyCode(),

decimalPlaces: $customField->getDecimalPlaces(),

);

} else {

$entry

->numeric(decimalPlaces: $customField->getDecimalPlaces())

->suffix(' ' . $customField->getCurrencyCode());

}

return $entry;

Copilot · 2026-03-25T12:36:09Z

tests/Feature/Filament/Components/CurrencyFieldComponentsTest.php

+    it('creates a text entry with money formatting', function (): void {
+        $field = CustomField::factory()->ofType('currency')->create();
+
+        $entry = (new CurrencyEntry)->make($field);
+
+        expect($entry)->toBeInstanceOf(BaseTextEntry::class);
+    });
+
+    it('creates an entry for fields with zero decimal places', function (): void {
+        $field = CustomField::factory()->ofType('currency')->create([
+            'settings' => ['additional' => ['decimal_places' => 0]],
+        ]);
+
+        $entry = (new CurrencyEntry)->make($field);
+
+        expect($entry)->toBeInstanceOf(BaseTextEntry::class);
+    });
+});


The CurrencyEntry tests also only assert the base class type and don’t validate formatting/decimal place configuration. Consider asserting that the entry’s formatter is configured (currency code + decimal places) so the intended display consistency is actually tested.

Copilot · 2026-03-25T12:36:09Z

src/FieldTypeSystem/Definitions/CurrencyFieldType.php

+                                $formatter = new NumberFormatter('en_US', NumberFormatter::CURRENCY);
+                                $formatter->setAttribute(NumberFormatter::FRACTION_DIGITS, $digits);
+                                $sample = $formatter->formatCurrency(1200.50, $code) ?: number_format(1200.50, $digits);
+


NumberFormatter is used here to generate sample labels. Without ext-intl, this will throw a fatal error when rendering the settings form. Consider requiring ext-intl or providing a safe fallback (e.g., number_format() samples) when NumberFormatter is unavailable.

Suggested change

$formatter = new NumberFormatter('en_US', NumberFormatter::CURRENCY);

$formatter->setAttribute(NumberFormatter::FRACTION_DIGITS, $digits);

$sample = $formatter->formatCurrency(1200.50, $code) ?: number_format(1200.50, $digits);

$sample = number_format(1200.50, $digits);

if (class_exists(NumberFormatter::class)) {

$formatter = new NumberFormatter('en_US', NumberFormatter::CURRENCY);

$formatter->setAttribute(NumberFormatter::FRACTION_DIGITS, $digits);

$formatted = $formatter->formatCurrency(1200.50, $code);

if ($formatted !== false) {

$sample = $formatted;

}

}

Copilot · 2026-03-25T12:36:09Z

src/Models/CustomField.php

+
+    public function getDecimalPlaces(int $default = 2): int
+    {
+        return $this->getCurrencySettings()->decimalPlaces;


getDecimalPlaces(int $default = 2) declares a $default parameter but never uses it. Either remove the parameter or use it as a fallback when decimal_places is missing to avoid misleading callers.

Suggested change

return $this->getCurrencySettings()->decimalPlaces;

return $this->getCurrencySettings()->decimalPlaces ?? $default;

Copilot · 2026-03-25T12:36:10Z

src/FieldTypeSystem/Definitions/CurrencyFieldType.php

+                            foreach ([0, 2, 3] as $digits) {
+                                $formatter = new NumberFormatter('en_US', NumberFormatter::CURRENCY);
+                                $formatter->setAttribute(NumberFormatter::FRACTION_DIGITS, $digits);
+                                $sample = $formatter->formatCurrency(1200.50, $code) ?: number_format(1200.50, $digits);
+
+                                $label = $digits === 0 ? 'No decimals' : $digits.' decimals';
+                                $options[(string) $digits] = sprintf('%s (%s)', $label, $sample);
+                            }


The decimal places UI only offers [0, 2, 3], but the codebase/tests support 4 decimal places (e.g. legacy validation_rules.decimal_places = 4 and component step tests). Consider adding 4 here (or aligning tests/legacy fallback to the allowed set) to avoid an unconfigurable-but-supported value.

- Use PHP intl ResourceBundle for dynamic, translatable currency list - Auto-detect decimal places per currency from NumberFormatter (JPY=0, BHD=3) - Filter historical/obsolete currencies automatically - Locale-aware: currency names translate with app()->getLocale() - Config override via custom-fields.currency.currencies for custom lists - Remove 50-currency hardcoded array from CurrencyFieldType

ManukMinasyan and others added 6 commits March 19, 2026 22:10

feat: add CurrencyColumn with numeric formatting and dollar prefix

31970e2

Fix styling

05e0328

feat: add CurrencyEntry with numeric formatting and dollar prefix

366e35e

Fix styling

69389bc

fix: remove hardcoded constraints from CurrencyComponent, respect dec…

aa7d789

…imal places

feat: wire CurrencyColumn/CurrencyEntry and add export transformer

ff14d13

Copilot AI review requested due to automatic review settings March 19, 2026 18:58

Copilot started reviewing on behalf of ManukMinasyan March 19, 2026 18:59 View session

Copilot AI reviewed Mar 19, 2026

View reviewed changes

ManukMinasyan and others added 8 commits March 19, 2026 23:04

fix: restore nullsafe operator on validation_rules access

32e2535

validation_rules is nullable in the database. When a custom field has null validation_rules, calling ->get() on null crashes. The nullsafe operator ?-> was incorrectly removed by a PHPStan "fix".

fix: use afterStateHydrated instead of default for currency settings …

f6b4fe8

…selects default() doesn't reliably hydrate existing records. afterStateHydrated ensures correct values on both create and edit forms. Cast decimal_places options to strings for select component compatibility.

fix: preserve existing column formatters in table visibility wrapper

12da118

the visibility check wrapper was overwriting any formatStateUsing set by the column type (e.g. CurrencyColumn). now captures and re-evaluates the existing formatter when the field is visible.

fix: resolve rector violations in currency-related files

3021646

apply LocallyCalledStaticMethodToNonStaticRector, EncapsedStringsToSprintfRector, and NewlineBeforeNewAssignSetRector fixes flagged by CI.

fix: resolve rector violation in decimal places options

3d9531e

Fix styling

023390d

ManukMinasyan closed this Mar 25, 2026

ManukMinasyan reopened this Mar 25, 2026

ManukMinasyan requested a review from Copilot March 25, 2026 12:30

Copilot started reviewing on behalf of ManukMinasyan March 25, 2026 12:30 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

	decimalPlaces: $customField->getDecimalPlaces(),
	decimalPlaces: $customField->getDecimalPlaces(),
	currencyDisplay: $customField->getCurrencyDisplayType(),

-    {
+    {
+        if (! class_exists(NumberFormatter::class)) {
+            return $currencyCode;
+        }

	return $this->getCurrencySettings()->decimalPlaces;
	return $this->getCurrencySettings()->decimalPlaces ?? $default;

Conversation

ManukMinasyan commented Mar 19, 2026

Summary

Behavior changes

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants