Use homogenous tuple annotation in BaseStateMeta.__new__

[masenf]

No description provided.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing masenf/base-state-meta-type-hint (566b9a6) with main (be43052)}

Summary

✅ 8 untouched benchmarks

[greptile-apps]

Greptile Summary

Corrected type annotation in BaseStateMeta.__new__ from tuple[type] to tuple[type, ...] for the bases parameter. The original annotation incorrectly specified a tuple with exactly one element, while metaclass __new__ methods receive a tuple of zero or more base classes. The new annotation properly represents a homogenous tuple of variable length.

• Fixed incorrect type annotation that would have caused type checker issues
• Note: reflex/components/field.py:70 has the same issue in FieldBasedMeta.__new__ that wasn't addressed in this PR

Confidence Score: 4/5

• This PR is safe to merge with minimal risk - it's a pure type annotation fix
• The change correctly fixes an invalid type annotation from tuple[type] (exactly one element) to tuple[type, ...] (variable length). This is a standard pattern for metaclass __new__ signatures. However, the same issue exists in another file (field.py) which suggests this fix is incomplete, preventing a perfect score.
• No files require special attention - this is a straightforward type annotation fix

Important Files Changed

Filename	Overview
reflex/vars/base.py	Fixed type annotation from tuple[type] to tuple[type, ...] in BaseStateMeta.__new__ to correctly represent variable-length tuple

Sequence Diagram

sequenceDiagram
    participant Python as Python Interpreter
    participant Meta as BaseStateMeta
    participant Type as type/ABCMeta
    
    Note over Python,Type: Class Definition Phase
    Python->>Meta: __new__(cls, name, bases, namespace, mixin)
    Note over Meta: bases: tuple[type, ...]<br/>(0 or more base classes)
    Meta->>Meta: Extract state_bases from bases
    Meta->>Meta: Process inherited_fields from bases
    Meta->>Meta: Process own_fields from namespace
    Meta->>Type: super().__new__(cls, name, bases, namespace)
    Type-->>Meta: New class instance
    Meta-->>Python: Return configured class

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: Same issue exists in reflex/components/field.py:70 where FieldBasedMeta.__new__ still uses tuple[type] instead of tuple[type, ...]

Prompt To Fix With AI

This is a comment left during a code review.
Path: reflex/vars/base.py
Line: 3540:3540

Comment:
**style:** Same issue exists in `reflex/components/field.py:70` where `FieldBasedMeta.__new__` still uses `tuple[type]` instead of `tuple[type, ...]`

How can I resolve this? If you propose a fix, please make it concise.