Skip to content

Conversation

@carlosabadia
Copy link
Collaborator

No description provided.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 21, 2026

Greptile Summary

Refactored the accordion styling in the sidebar component by extracting the box-shadow CSS property from Tailwind's arbitrary value syntax into a dedicated style prop. This improves code organization by separating inline styles from utility classes, making the styling more maintainable and explicit.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a straightforward styling refactor that extracts a box-shadow CSS property from Tailwind's arbitrary syntax to an inline style prop. The functionality remains identical, and the change improves code maintainability by better separating concerns. No logic changes, no security implications.
  • No files require special attention

Important Files Changed

Filename Overview
pcweb/components/docpage/sidebar/sidebar.py Refactored box-shadow from Tailwind arbitrary syntax to inline style prop for cleaner separation of concerns

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Component as Accordion Component
    participant Style as Style Rendering
    
    Dev->>Component: Update accordion.root props
    Note over Dev,Component: Separate box-shadow from class_name
    Dev->>Component: Add style prop with box-shadow
    Dev->>Component: Update class_name (remove box-shadow)
    Component->>Style: Render with style prop
    Component->>Style: Apply Tailwind classes
    Style-->>Component: Styled accordion with box-shadow
Loading

@Kastier1 Kastier1 merged commit d4595bc into main Jan 21, 2026
11 checks passed
@Kastier1 Kastier1 deleted the carlos/fix-accordion-styling branch January 21, 2026 17:41
carlosabadia added a commit that referenced this pull request Jan 21, 2026
tgberkeley pushed a commit that referenced this pull request Jan 22, 2026
* ENG-8666: ENG-8667: Update intro docs

* Update accordion styling (#1733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants