Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Windows build support by addressing several configuration and compatibility issues. The main changes focus on making the code more compatible across platforms, particularly for Windows builds.
- Updates replication settings to use optional dst_token field instead of required string
- Adds proper Windows build configuration and Conan package management support
- Fixes CI workflow to properly handle Windows and Linux builds separately
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/replication_api_test.cc | Updates test cases to remove hardcoded dst_token assignments and updates test tags |
| src/internal/serialisation.cc | Modifies JSON serialization to handle optional dst_token field properly |
| src/client.h | Changes dst_token from string to optional for better null handling |
| examples/ | Adds new Conan test files and updates CMake configuration for Windows compatibility |
| conanfile.py | Improves Conan packaging for Windows builds with better library detection |
| .github/workflows/ci.yml | Restructures CI to separate Windows and Linux builds with proper dependency management |
| .github/actions/ | Updates build actions to handle Windows-specific configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What was changed?
The PR recovers Windwos support.
Related issues
(Add links to related issues)
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information: