Skip to content

Fix Windows build#94

Merged
atimin merged 44 commits intomainfrom
windows-build
Oct 10, 2025
Merged

Fix Windows build#94
atimin merged 44 commits intomainfrom
windows-build

Conversation

@atimin
Copy link
Copy Markdown
Member

@atimin atimin commented Oct 10, 2025

Closes #

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Bug fix

What was changed?

The PR recovers Windwos support.

Related issues

(Add links to related issues)

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

Other information:

@atimin atimin requested a review from Copilot October 10, 2025 20:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Windows build support by addressing several configuration and compatibility issues. The main changes focus on making the code more compatible across platforms, particularly for Windows builds.

  • Updates replication settings to use optional dst_token field instead of required string
  • Adds proper Windows build configuration and Conan package management support
  • Fixes CI workflow to properly handle Windows and Linux builds separately

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/replication_api_test.cc Updates test cases to remove hardcoded dst_token assignments and updates test tags
src/internal/serialisation.cc Modifies JSON serialization to handle optional dst_token field properly
src/client.h Changes dst_token from string to optional for better null handling
examples/ Adds new Conan test files and updates CMake configuration for Windows compatibility
conanfile.py Improves Conan packaging for Windows builds with better library detection
.github/workflows/ci.yml Restructures CI to separate Windows and Linux builds with proper dependency management
.github/actions/ Updates build actions to handle Windows-specific configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/reduct/internal/serialisation.cc Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/actions/build-package-system/action.yml Outdated
Comment thread .github/actions/build-package-vcpkg/action.yml Outdated
@atimin atimin merged commit 6638a8c into main Oct 10, 2025
18 checks passed
@atimin atimin deleted the windows-build branch October 10, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants