Add namespace parameter to redpanda license command#1588
Add namespace parameter to redpanda license command#1588jason-da-redpanda wants to merge 2 commits intomainfrom
Conversation
Updated the kubectl command to include the namespace parameter. well the \ specifically
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis change updates documentation for Kubernetes Secret creation in the Redpanda getting started guide. The kubectl command is modified to include a line continuation character and a namespace flag, allowing users to specify the target namespace when creating the license secret. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
urgh,,, needs another \ |
needs \ + \
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@modules/get-started/pages/licensing/add-license-redpanda/kubernetes.adoc`:
- Around line 28-30: The kubectl secret creation command is missing a
line-continuation backslash at the end of the first line ("kubectl create secret
generic redpanda-license"), causing the shell to treat the next line as a
separate (invalid) command; fix by adding a trailing backslash to that first
line and keep the subsequent lines as continued arguments (optionally indent
continuation lines for consistency with the other multi-line kubectl example
such as the update command).
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
modules/get-started/pages/licensing/add-license-redpanda/kubernetes.adoc
| kubectl create secret generic redpanda-license | ||
| --from-file=license=./redpanda.license | ||
| --from-file=license=./redpanda.license \ | ||
| --namespace <namespace> |
There was a problem hiding this comment.
Critical: Missing line continuation backslash on line 28.
The kubectl command will fail because line 28 doesn't end with a backslash (\). Without it, bash executes line 28 as a complete command, then treats --from-file on line 29 as an invalid command.
🐛 Proposed fix
-kubectl create secret generic redpanda-license
---from-file=license=./redpanda.license \
+kubectl create secret generic redpanda-license \
+ --from-file=license=./redpanda.license \
+ --namespace <namespace>Note: Added 2-space indentation to continuation lines for consistency with the update command at lines 205-207.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@modules/get-started/pages/licensing/add-license-redpanda/kubernetes.adoc`
around lines 28 - 30, The kubectl secret creation command is missing a
line-continuation backslash at the end of the first line ("kubectl create secret
generic redpanda-license"), causing the shell to treat the next line as a
separate (invalid) command; fix by adding a trailing backslash to that first
line and keep the subsequent lines as continued arguments (optionally indent
continuation lines for consistency with the other multi-line kubectl example
such as the update command).
micheleRP
left a comment
micheleRP
left a comment
There was a problem hiding this comment.
thank you @jason-da-redpanda!
2 participants
Updated the kubectl command to include the namespace parameter. well the \ specifically
Description
Resolves https://redpandadata.atlassian.net/browse/
Review deadline:
Page previews
Checks