Conversation
|
@adahms can you please take a look at the packaging/installation script and the respective section of the README file? |
adahms
left a comment
adahms
left a comment
There was a problem hiding this comment.
Hey @Levi-Leah - on the whole, this works for me.
One area where we might run into issues is with the value of the 'Release' attribute in the spec file. The script correctly identifies and passes the version to make.sh, but all that's doing today is helping the script identify the right sources, etc. to use.
How would you feel about taking a similar approach to the OSX script? I.e. doing away with RPMS all together and copying the source files into a directory under /usr/bin or somewhere similar?
That could help remove some steps for adding files to the spec file each time we make a change and simplify the overall process.
linux-cmd-intallation.sh
Outdated
| # clone repo | ||
|
|
||
| # install required packages | ||
| sudo dnf install subversion |
There was a problem hiding this comment.
Can we make this a one-liner, perhaps?
E.g. sudo dnf install subversion rpm-build
|
@adahms I reworked the linux installation script to be similar to the mac one. would you mind taking a look? |
| echo 'Adding an alias to ~/.zshrc file...' | ||
|
|
||
| alias pcmd="/usr/local/bin/python3 /usr/local/bin/PantheonCMD/pcmd.py $@" | ||
| alias pcmd="/usr/bin/python3 /usr/local/bin/PantheonCMD/pcmd.py $@" |
There was a problem hiding this comment.
in linux this command gives an exit code 0, which terminates the script. is it the same on mac? in which case I can change it to this:
| alias pcmd="/usr/bin/python3 /usr/local/bin/PantheonCMD/pcmd.py $@" | |
| set +e && alias pcmd="/usr/bin/python3 /usr/local/bin/PantheonCMD/pcmd.py $@" |
| if [[ $SHELL = '/bin/bash' ]]; then | ||
| set +e && alias pcmd='/usr/bin/python3 /usr/local/bin/PantheonCMD/pcmd.py $@' && source ~/.bashrc | ||
| elif [[ $SHELL = '/bin/tcsh' ]]; then | ||
| set +e && alias pcmd '/usr/bin/python3 /usr/local/bin/PantheonCMD/pcmd.py $@' && source ~/.tcshrc | ||
| elif [[ $SHELL = '/bin/csh' ]]; then | ||
| set +e && alias pcmd '/usr/bin/python3 /usr/local/bin/PantheonCMD/pcmd.py $@' && source ~/.cshrc | ||
| fi |
There was a problem hiding this comment.
I'm not sure if we should account for various shells or just roll with bash
| sudo dnf install python3 ruby subversion rpm-build | ||
|
|
||
| echo 'Installing ruby gem dependencies...' | ||
| sudo gem install asciidoctor concurrent-ruby haml tilt |
There was a problem hiding this comment.
smth here isn't quite right, I get a deprecation message
DEPRECATION: Configuring installation scheme with distutils config files is deprecated and will no longer work in the near future. If you are using a Homebrew or Linuxbrew Python, please see discussion at https://github.com/Homebrew/homebrew-core/issues/76621 Requirement already satisfie
2 participants
No description provided.