Add verify-procedure skill#12
Closed
kquinn1204 wants to merge 2 commits intoredhat-documentation:mainfrom
Closed
Conversation
af8c29f to
f7b8e05
Compare
Member
|
Thanks for the PR Kevin. Note this duplicates a lot of existing functionality, and some of the skills are not suitable for this repo. Suggest reviewing what's in the repo currently, and focusing the PR on net new skills and updates only. |
aireilly
reviewed
Mar 11, 2026
|
|
||
| This skill uses the `task_step.rb` Ruby script to find procedure steps that contain multi-block content without proper list continuation markers (`+`) and adds them. | ||
|
|
||
| ## AI Action Plan |
Member
There was a problem hiding this comment.
aireilly
reviewed
Mar 11, 2026
| @@ -0,0 +1,538 @@ | |||
| --- | |||
| description: Intelligently cherry-pick documentation changes to enterprise branches, excluding files that don't exist on each target release | |||
Member
There was a problem hiding this comment.
this is openshift specific, it's not a general skill.
f7b8e05 to
33bb737
Compare
aireilly
reviewed
Mar 11, 2026
| @@ -0,0 +1,29 @@ | |||
| --- | |||
Member
There was a problem hiding this comment.
This seems to duplicate functionality from the technical-reviewer agent, and also I don't know what the verify_proc script actually does?
Author
There was a problem hiding this comment.
I have updated the skill so it should apply across multiple products though have only tried with OCP can still decide not to add to repo up to you
33bb737 to
72b5f5e
Compare
f5061ed to
668c4ce
Compare
500dd1f to
a09450c
Compare
- Update install links to marketplace URL across all plugin READMEs - Add AsciiDocDITA Vale validation note to dita-tools README and both rework modes in dita-rework command Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Adds a new docs-tools skill that executes AsciiDoc procedures against a live system to prove they work end-to-end. Requires an active connection (oc login, SSH, etc.) — for offline review, use the technical-reviewer agent instead. The Ruby script (verify_proc.rb) parses the .adoc file, extracts numbered steps and their source blocks, then runs each one sequentially. It validates YAML syntax and dry-runs Kubernetes resources, executes bash commands, skips example output and placeholder blocks, and reports a pass/fail summary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a09450c to
ab1e687
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
verify-procedureskill to docs-tools. This skill executes AsciiDoc procedures against a live system to prove they work end-to-end — it is the "guided exercise tester" for documentation.3 files changed, 1 commit. No changes to dita-tools or any other existing plugin.
What it does
This skill requires an active connection to the target system (
oc login, SSH, etc.). It is not a review tool — for offline documentation review, use thetechnical-revieweragent instead.How it works
.adocfile to extract all[source,terminal],[source,bash], and[source,yaml]blocks, associating each with its numbered stepverify_proc.rbRuby script against the fileWhat the Ruby script does (
verify_proc.rb). Step text) and associates each[source,yaml],[source,terminal], or[source,bash]block with its parent stepapiVersion:detected), runsoc apply --dry-run=clientorkubectl apply --dry-run=client(auto-detects which CLI is available)$prompts, joins backslash-continued lines, executes each command, captures stdout/stderr/exit code. On failure, logs the error and continues to the next step<placeholder>,${VAR},CHANGEME,REPLACE)oc login,ssh,sudo,subscription-manager,dnf install,ansible-playbook, etc.) and warns about potential "magic steps" if none are foundProduct support
The script is product-agnostic. It runs whatever commands are in the doc:
occommands execute, YAML dry-run viaoc applydnf,systemctl,nmclietc. execute on the local machineopenstackCLI commands execute if installed and sourcedansible-playbook,ansible-navigatorexecute if installedExample output
Relationship to technical-reviewer agent
Files changed
plugins/docs-tools/skills/verify-procedure/SKILL.md— skill definitionplugins/docs-tools/skills/verify-procedure/scripts/verify_proc.rb— Ruby execution scriptplugins/docs-tools/.claude-plugin/plugin.json— version bump 0.0.2 → 0.0.3