Record 'java.clean.workspace' invocations in telemetry#3058
Merged
rgrunber merged 1 commit intoredhat-developer:masterfrom Apr 12, 2023
Merged
Record 'java.clean.workspace' invocations in telemetry#3058rgrunber merged 1 commit intoredhat-developer:masterfrom
rgrunber merged 1 commit intoredhat-developer:masterfrom
Conversation
rgrunber
reviewed
Apr 11, 2023
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Looks good overall, just some minor points.
I think once we get more of these, we should probably go with an approach similar to https://github.com/redhat-developer/vscode-quarkus/blob/0448e38c235ef0368057f7cc2ad021d52e577df3/src/commands/registerCommands.ts#L71 for commands.
Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon
force-pushed
the
clean-telemetry
branch
from
20daa0c to
a01f506
Compare
Collaborator
Author
|
Sure, but clean workspace is special, for now, a the event is not sent on shutdown for some reason |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fred Bricon fbricon@gmail.com