Ignore .github/ and .gitignore from packaging#3057
Merged
rgrunber merged 1 commit intoredhat-developer:masterfrom Apr 11, 2023
Merged
Ignore .github/ and .gitignore from packaging#3057rgrunber merged 1 commit intoredhat-developer:masterfrom
rgrunber merged 1 commit intoredhat-developer:masterfrom
Conversation
Signed-off-by: Fred Bricon <fbricon@gmail.com>
rgrunber
approved these changes
Apr 11, 2023
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
This is fine to me. I don't see any files under .github/ or .gitignore itself end up in the vsix when i package it though. Is it a platform specific issue or just for the sake of clarity that you have them there.
Contributor
|
LGTM to explicit exclude them. |
Contributor
See https://github.com/microsoft/vscode-vsce/blob/main/src/package.ts#L1489-L1523 |
Collaborator
Author
|
made the PR because I saw we had that issue in vscode-xml : redhat-developer/vscode-xml#891 doesn't hurt in any case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fred Bricon fbricon@gmail.com