Skip to content

Conversation

@debsmita1
Copy link
Member

@debsmita1 debsmita1 commented Dec 30, 2025

Description

Based on the spike https://docs.google.com/document/d/1nv2ITnWXeGiqjNVCFjhsEPL11M3zjha93y2KdS0ZPz0/edit?usp=sharing , this PR implements the following:
-> Added two new mount points for dynamic plugins:
- application/internal/drawer-state : Exposes the plugin's drawer state (isDrawerOpen, drawerWidth, setDrawerWidth) to RHDH via callback props
- application/internal/drawer-content : Defines the drawer's content component along with configuration options:
id: Unique drawer identifier
resizable: Boolean to enable/disable drawer resizing

Note: The mount points added are for internal use only and are subject to change. These will be updated with the introduction of the new frontend system.

-> ApplicationDrawer Component, which renders all application/internal/drawer-state components, collects drawer states via callback props, and evaluates the open drawer and closes the previously open drawer

New dynamic plugin config

red-hat-developer-hub.backstage-plugin-lightspeed:
      dynamicRoutes:
        - path: /lightspeed
          importName: LightspeedPage
        - path: /lightspeed/conversation/:id
          importName: LightspeedPage
      mountPoints:
        - mountPoint: application/listener
          importName: LightspeedFAB
        - mountPoint: application/provider
          importName: LightspeedDrawerProvider
        - mountPoint: application/internal/drawer-state
          importName: LightspeedDrawerStateExposer
        - mountPoint: application/internal/drawer-content
          importName: LightspeedChatContainer
          config:
            id: lightspeed
            priority: 100
    red-hat-developer-hub.backstage-plugin-quickstart:
            translationResources:
              - importName: quickstartTranslations
                ref: quickstartTranslationRef
            mountPoints:
              - mountPoint: application/provider
                importName: QuickstartDrawerProvider
              - mountPoint: application/internal/drawer-state
                importName: QuickstartDrawerStateExposer
              - mountPoint: application/internal/drawer-content
                importName: QuickstartDrawerContent
                config:
                  id: quickstart
              - mountPoint: global.header/help
                importName: QuickstartButton
                config:
                  priority: 100

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@debsmita1 debsmita1 changed the title add new drawer mount point feat: add new drawer mount point Dec 30, 2025
@debsmita1 debsmita1 force-pushed the add-drawer-mountpoint branch from 7e2010f to c539d1e Compare December 30, 2025 10:50
@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

The image is available at:

/test e2e-ocp-helm

@github-actions github-actions bot removed the Stale label Jan 9, 2026
@debsmita1
Copy link
Member Author

Copy link
Contributor

@HusneShabbir HusneShabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@debsmita1 debsmita1 changed the title feat: add new drawer mount point feat: add new drawer mount points Jan 9, 2026
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just one small comment.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Copy link
Contributor

@HusneShabbir HusneShabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally,
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 9, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HusneShabbir
Once this PR has been reviewed and has the lgtm label, please ask for approval from christoph-jerolimov. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

The image is available at:

/test e2e-ocp-helm

Copy link
Contributor

@HusneShabbir HusneShabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jan 10, 2026

@debsmita1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 8ae94c0 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants