-
Notifications
You must be signed in to change notification settings - Fork 211
feat: add new drawer mount points #3947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The image is available at: /test e2e-ocp-helm |
7e2010f to
c539d1e
Compare
|
The image is available at: /test e2e-ocp-helm |
c539d1e to
bec5b87
Compare
|
The image is available at: /test e2e-ocp-helm |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
bec5b87 to
0982060
Compare
0982060 to
c064d02
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
c064d02 to
9bdf299
Compare
|
The image is available at: /test e2e-ocp-helm |
HusneShabbir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
rohitkrai03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Just one small comment.
9bdf299 to
a3ad60a
Compare
a3ad60a to
f032b7a
Compare
f032b7a to
8ae94c0
Compare
|
HusneShabbir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally,
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HusneShabbir The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
The image is available at: /test e2e-ocp-helm |
HusneShabbir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
|
@debsmita1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |



Description
Based on the spike https://docs.google.com/document/d/1nv2ITnWXeGiqjNVCFjhsEPL11M3zjha93y2KdS0ZPz0/edit?usp=sharing , this PR implements the following:
-> Added two new mount points for dynamic plugins:
-
application/internal/drawer-state: Exposes the plugin's drawer state (isDrawerOpen, drawerWidth, setDrawerWidth) to RHDH via callback props-
application/internal/drawer-content: Defines the drawer's content component along with configuration options:id: Unique drawer identifier
resizable: Boolean to enable/disable drawer resizing
Note: The mount points added are for internal use only and are subject to change. These will be updated with the introduction of the new frontend system.
-> ApplicationDrawer Component, which renders all
application/internal/drawer-statecomponents, collects drawer states via callback props, and evaluates the open drawer and closes the previously open drawerNew dynamic plugin config
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer