Upgrade Dockerfile to python3#118
Open
adrian-marza-mambu wants to merge 1 commit intoredhat-aqe:masterfrom
Open
Upgrade Dockerfile to python3#118adrian-marza-mambu wants to merge 1 commit intoredhat-aqe:masterfrom
adrian-marza-mambu wants to merge 1 commit intoredhat-aqe:masterfrom
Conversation
The container can't be built with python2 anymore, so we might as well switch to the python3 packages fully.
Author
|
@pbortlov @danrodrig @ralphbean PTAL if you get a chance |
Contributor
|
@adrian-marza-mambu I didn't look into this project since quite a while and I never used the container image. However, I did a quick check. I built and run the image with Podman and I was able to check some reviews, LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container can't be built with python2 anymore, so we might as well switch to the python3 packages fully.
The error appears at docker build:
After this fix docker-build works:
docker build -t review-rot:latest . ... Successfully tagged review-rot:latest docker run --rm -it review-rot:latest bash review-rot --help ...