Skip to content

controllers: fix panic on resolving tolerations#526

Merged
openshift-merge-bot[bot] merged 1 commit intored-hat-storage:mainfrom
leelavg:fix-tol
Mar 4, 2026
Merged

controllers: fix panic on resolving tolerations#526
openshift-merge-bot[bot] merged 1 commit intored-hat-storage:mainfrom
leelavg:fix-tol

Conversation

@leelavg
Copy link
Contributor

@leelavg leelavg commented Mar 4, 2026

subscription.Spec.Config is a pointer field which isn't always set on client only clusters.

subscription.Spec.Config is a pointer field which isn't always set on
client only clusters.

Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
@leelavg
Copy link
Contributor Author

leelavg commented Mar 4, 2026

regression from #519, earlier PR was only tested in hub cluster where odf-op usually initializes .spec.config burying the panic on standalone clusters.

@shirady reported the failure.

@leelavg
Copy link
Contributor Author

leelavg commented Mar 4, 2026

/hold

testing in progress

@nb-ohad
Copy link
Contributor

nb-ohad commented Mar 4, 2026

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg
Copy link
Contributor Author

leelavg commented Mar 4, 2026

/unhold

verified fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants