feat: add as_pint to read_relative() and extract _apply_pint_dtype helper#9
Open
CooperBigFoot wants to merge 1 commit intorebase-energy:mainfrom
Open
Conversation
Collaborator
|
Thank you for the PR! Can you please only change code that is related to this PR and drop the bump my version part? Then I can review it again! |
1361758 to
467674f
Compare
Author
|
Cleaned up. Force-pushed with only the issue #8 changes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read()into a reusable_apply_pint_dtype(df, unit)helper (handles empty DataFrames, copies before mutating)as_pint: bool = Falsekeyword-only parameter toread_relative(), matching the existingread()APIIncompatibleUnitErroroninsert()docstringTest plan
_apply_pint_dtype(empty df, applies dtype, no mutation, magnitude preserved)read_relative(as_pint=True/False)Closes #8