Update test-emitter-on-off.py to handle D415#14607
Open
ttkhuong wants to merge 1 commit intorealsenseai:developmentfrom
Open
Update test-emitter-on-off.py to handle D415#14607ttkhuong wants to merge 1 commit intorealsenseai:developmentfrom
ttkhuong wants to merge 1 commit intorealsenseai:developmentfrom
Conversation
|
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the D400 emitter test to handle D415 devices, which have low contrast emitter behavior. The changes override test parameters specifically for D415 to use auto exposure and a lower contrast threshold.
Changes:
- Removed outdated test directive (
#test:donotrun) to re-enable the test - Added device-specific parameter overrides for D415 (auto exposure and lower contrast threshold)
- Enhanced documentation with detailed test descriptions and parameter explanations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Rebase |
Contributor
Author
|
Trigger LibCI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D415 emitter has low contrast.
Update parameters to use auto exposure and lower CONTRAST_DIFF_THRESHOLD to 5.0 for D415