Skip to content

Add D400_CAM_SYNC directive to libCI framework and initial cam_sync tests#14501

Open
ttkhuong wants to merge 1 commit intorealsenseai:developmentfrom
ttkhuong:RSDSO-20709
Open

Add D400_CAM_SYNC directive to libCI framework and initial cam_sync tests#14501
ttkhuong wants to merge 1 commit intorealsenseai:developmentfrom
ttkhuong:RSDSO-20709

Conversation

@ttkhuong
Copy link
Contributor

@ttkhuong ttkhuong commented Dec 9, 2025

  1. Add special composite categories D400_CAM_SYNC
  2. D400_CAM_SYNC requires two D400 devices, excluding D405 (no sync port)
  3. Added libCI tests for sync mode and sync verification
  4. Added test-sync-mode.py
  5. Added test-sync-depth-fps-performance.py
  6. Added test-sync-stream.py (disable for now)

Requirements:

  • Two D400 cameras (D405 excluded as it lacks sync port)
  • Cameras are connected via sync cable
  • FW version >= 5.15.0.0 for inter_cam_sync_mode support

@ttkhuong ttkhuong changed the title Add test-master-slave-mode.py D400: Add master-slave test cases Dec 9, 2025
@ttkhuong ttkhuong marked this pull request as draft December 9, 2025 23:23
@ttkhuong ttkhuong force-pushed the RSDSO-20709 branch 5 times, most recently from 28a96e9 to f2e7847 Compare December 11, 2025 21:23
@sysrsbuild-gh
Copy link

Can one of the admins verify this patch?

@ttkhuong ttkhuong changed the title D400: Add master-slave test cases D400: Add camera sync test cases Dec 11, 2025
@ttkhuong ttkhuong marked this pull request as ready for review December 11, 2025 23:48
@ttkhuong ttkhuong force-pushed the RSDSO-20709 branch 5 times, most recently from a180e91 to 4bbd916 Compare December 15, 2025 23:03
@ttkhuong ttkhuong changed the title D400: Add camera sync test cases Tracked-On RSDSO-20709 - Add camera sync to libCI framework Dec 15, 2025
@ttkhuong ttkhuong changed the title Tracked-On RSDSO-20709 - Add camera sync to libCI framework Add D400_CAM_SYNC directive to libCI framework Dec 17, 2025
@ttkhuong ttkhuong changed the title Add D400_CAM_SYNC directive to libCI framework Add D400_CAM_SYNC directive to libCI framework and initial cam_sync tests Dec 19, 2025
Copilot AI review requested due to automatic review settings January 15, 2026 23:13
@ttkhuong
Copy link
Contributor Author

Rebase

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for synchronized dual-camera testing in the libCI framework by introducing the D400_CAM_SYNC device directive and implementing comprehensive sync mode tests.

Changes:

  • Added D400_CAM_SYNC composite category requiring two D400 devices (excluding D405)
  • Implemented inter-camera sync mode tests including mode configuration, FPS performance validation, and timestamp drift analysis
  • Added three test files for sync functionality validation

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
unit-tests/py/rspy/libci.py Added documentation comment for D400_CAM_SYNC directive
unit-tests/py/rspy/devices.py Implemented D400_CAM_SYNC composite category logic with device selection and validation
unit-tests/live/camera-sync/test-sync-stream.py Comprehensive timestamp drift analysis test comparing MASTER-SLAVE vs DEFAULT sync modes
unit-tests/live/camera-sync/test-sync-mode.py Basic sync mode configuration validation test
unit-tests/live/camera-sync/test-sync-depth-fps-performance.py Dual-camera FPS accuracy test for all supported depth configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants