Add D400_CAM_SYNC directive to libCI framework and initial cam_sync tests#14501
Open
ttkhuong wants to merge 1 commit intorealsenseai:developmentfrom
Open
Add D400_CAM_SYNC directive to libCI framework and initial cam_sync tests#14501ttkhuong wants to merge 1 commit intorealsenseai:developmentfrom
ttkhuong wants to merge 1 commit intorealsenseai:developmentfrom
Conversation
28a96e9 to
f2e7847
Compare
|
Can one of the admins verify this patch? |
f2e7847 to
29c8405
Compare
a180e91 to
4bbd916
Compare
4bbd916 to
cc9f222
Compare
cc9f222 to
78f477a
Compare
Contributor
Author
|
Rebase |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for synchronized dual-camera testing in the libCI framework by introducing the D400_CAM_SYNC device directive and implementing comprehensive sync mode tests.
Changes:
- Added D400_CAM_SYNC composite category requiring two D400 devices (excluding D405)
- Implemented inter-camera sync mode tests including mode configuration, FPS performance validation, and timestamp drift analysis
- Added three test files for sync functionality validation
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| unit-tests/py/rspy/libci.py | Added documentation comment for D400_CAM_SYNC directive |
| unit-tests/py/rspy/devices.py | Implemented D400_CAM_SYNC composite category logic with device selection and validation |
| unit-tests/live/camera-sync/test-sync-stream.py | Comprehensive timestamp drift analysis test comparing MASTER-SLAVE vs DEFAULT sync modes |
| unit-tests/live/camera-sync/test-sync-mode.py | Basic sync mode configuration validation test |
| unit-tests/live/camera-sync/test-sync-depth-fps-performance.py | Dual-camera FPS accuracy test for all supported depth configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements: