Skip to content

[Fix] calling navigate with number throws #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baptooo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Fix] calling navigate with number throws #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f277451
[Fix] calling navigate with number throws
Apr 25, 2022
142dab5
fix: add a test for this case
Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ let match = (path, uri) => pick([{ path }], uri);
// require less contextual information and (fingers crossed) be more intuitive.
let resolve = (to, base) => {
// /foo/bar, /baz/qux => /foo/bar
if (startsWith(to, "/")) {
if (typeof to === "number" || startsWith(to, "/")) {
return to;
}

Expand Down
1 change: 1 addition & 0 deletions src/lib/utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ describe("resolve", () => {
expect(resolve("/groups?some=query", "/users?some=thing")).toEqual(
"/groups?some=query"
);
expect(resolve(-1)).toEqual(-1);
});
});

Expand Down