Make fogColor in the fog tutorial a parameter#5672
Open
devel60-alt wants to merge 3 commits intoraysan5:masterfrom
Open
Make fogColor in the fog tutorial a parameter#5672devel60-alt wants to merge 3 commits intoraysan5:masterfrom
devel60-alt wants to merge 3 commits intoraysan5:masterfrom
Conversation
fogColor is now a parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty self explanatory, now the fogColor vec4 in fog.fs can be edited from code. I wasn't sure though if I should have converted the output of ColorNormalize to a float* like ambient used to be (most likely with another function, but I don't think it would have been necessary), so I decided to make them both Vector4's for consistency