-
Notifications
You must be signed in to change notification settings - Fork 665
[Feature] Support JobDeploymentStatus as the deletion condition #4262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JiangJiaWei1103
wants to merge
13
commits into
ray-project:master
Choose a base branch
from
JiangJiaWei1103:support-jobdeploymentstatus-as-del-cond
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8c2132a
feat: Support JobDeploymentStatus as the deletion condition
JiangJiaWei1103 596ed83
chore: Regenerate utility codes
JiangJiaWei1103 f0766c4
docs: Update api docs
JiangJiaWei1103 6ced1b6
fix(test): Change JobStatus of the deletion condition from val to ptr
JiangJiaWei1103 909fc40
test: Add JobDeploymentStatus-based e2e tests with four deletion poli…
JiangJiaWei1103 378cc23
test: Add validation tests for JobDeploymentStatus-based deletion rules
JiangJiaWei1103 1c0cf0b
fix: Sync CRD yaml files into helm chart
JiangJiaWei1103 72ed628
docs: Support JobDeploymentStatus as deletion condition
JiangJiaWei1103 aa8f8c1
refactor: Add a helper to check rule match
JiangJiaWei1103 1c6c28d
docs: Complete TTLSeconds description
JiangJiaWei1103 2386ea7
refactor: Keep validation logic aligned with kubebuilder
JiangJiaWei1103 1d9d0a4
refactor: Write helper for validating deletion condition
JiangJiaWei1103 83eb5eb
refactor: Simplify logic for assigning an empty map to track TTL by p…
JiangJiaWei1103 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.