Conversation
sjperkins
reviewed
Sep 28, 2023
Member
sjperkins
left a comment
There was a problem hiding this comment.
Minor comments, need to do some more reviewing here.
…eds to be fixes. Uncovered difficult edge case - adding columns after selection.
… table descriptor.
Member
|
Thought: Implement this down to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests added / passed
If the pep8 tests fail, the quickest way to correct
this is to run
autopep8and thenflake8andpycodestyleto fix the remaining issues.Fully documented, including
HISTORY.rstfor all changesand one of the
docs/*-api.rstfiles for new APITo build the docs locally:
This PR adds generic ID coordinates to datasets read by
dask-ms. This extends the existing ROWID functionality to all dimensions. The advantage of this approach is that it becomes possible to leverage the excellent xarray selection mechanisms without making writing to disk complicated e.g. a user may select and write out a channel subset without having to coerce the selected data into the same shape as the original.Currently, the new functionality works for multidimensional arrays but there remain a number of issues:
putcolbehaviour. This is not safe when using IDs as a single chunk may correspond to multiple locations on disk.dim_runs(extension ofrow_runs), regardless of chunking/data type. This currently causes dictionary writes to fail.putcolsliceunnecessarily in some cases.inlined_arraydue to mysterious bugs occurring in testing. This likely needs to be addressed for the purposes of maintaining a tidy graph.