Skip to content

Avoid explicit CASA read locking by opening tables in 'usernoread' mode#141

Open
sjperkins wants to merge 5 commits intomasterfrom
usernoread-locking-test
Open

Avoid explicit CASA read locking by opening tables in 'usernoread' mode#141
sjperkins wants to merge 5 commits intomasterfrom
usernoread-locking-test

Conversation

@sjperkins
Copy link
Copy Markdown
Member

  • Tests added / passed

    $ py.test -v -s daskms/tests

    If the pep8 tests fail, the quickest way to correct
    this is to run autopep8 and then flake8 and
    pycodestyle to fix the remaining issues.

    $ pip install -U autopep8 flake8 pycodestyle
    $ autopep8 -r -i daskms
    $ flake8 daskms
    $ pycodestyle daskms
    
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
    cd docs
    READTHEDOCS=True make html
    

@sjperkins sjperkins requested a review from JSKenyon February 8, 2021 14:53
@sjperkins
Copy link
Copy Markdown
Member Author

The test cases seem happy with this @JSKenyon. Want to give it a whirl?

@JSKenyon
Copy link
Copy Markdown
Collaborator

JSKenyon commented Feb 9, 2021

I gave this a whirl but I cannot see an obvious improvement:

Screenshot from 2021-02-09 10-10-01

The reads still seem to be locking up. Is it plausible that the tables are still being locked?

@sjperkins
Copy link
Copy Markdown
Member Author

@JSKenyon I've disabled locking on the TAQL queries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants