Dask ms profiling

[smasoka]

• Tests added / passed

  $ py.test -v -s daskms/tests

  If the pep8 tests fail, the quickest way to correct
  this is to run autopep8 and then flake8 and
  pycodestyle to fix the remaining issues.

  $ pip install -U autopep8 flake8 pycodestyle
  $ autopep8 -r -i daskms
  $ flake8 daskms
  $ pycodestyle daskms
  

• Fully documented, including HISTORY.rst for all changes
  and one of the docs/*-api.rst files for new API

  To build the docs locally:

  pip install -r requirements.readthedocs.txt
  cd docs
  READTHEDOCS=True make html
  

[sjperkins]

As _nolock_runner

[sjperkins]

As _writelock_runner

[sjperkins]

Start the test file from scratch.

def test_function_profiling():
    from daskms.table_proxy import _function_runs

   # Look at the rest of the test cases that use xds_from_ms
   # Set this one's arguments up similarly
   # Use xds_from_ms to produce datasets
   # then call compute on the datasets or the dataset arrays
   # that should invoke your profiling code
   # Whose results you can inspect in _function_runs

[smasoka]

The test code from test_ms_read_and_update.py does what I was. I will add more functions to test other proxied_methods in a similar way.
I am not sure why table_keywords changes to class type tuple inside _put_keywords function?

[sjperkins]

The test code from test_ms_read_and_update.py does what I was. I will add more functions to test other proxied_methods in a similar way.

OK, I can see that you've added a print function at the end of the test. I assume that this is what you're using to verify your results. Generally when one writes tests one should use assert statements on the output to verify correctness. Something like:

from numpy.testing import assert_array_equal, assert_array_almost_equal
assert x == 1                                  # Standard python equality
assert_array_equal(y, z)                # Test arrays are exactly equal
assert_array_almost_equal(y, z)   # Test arrays are minimally different from each other

I am not sure why table_keywords changes to class type tuple inside _put_keywords function?

Hmmmm, it shouldn't. Is a tuple being passed into xds_from_ms or xds_from_table?

xds_from_ms(..., table_keywords=('x', 'y'))

for instance.

[smasoka]

Yes, I am using assert statements.
I was printing to see results for myself and also track table_keywords so you can see my confusion a bit. I'll do another commit end of the day