-
Notifications
You must be signed in to change notification settings - Fork 182
[Cleanup] Combine Batched and Regular KMeans Impl #2015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tarang-jain
wants to merge
16
commits into
rapidsai:main
Choose a base branch
from
tarang-jain:combine-batch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
66d7fd3
combine impls
tarang-jain 0a09e6f
rm inertia_check
tarang-jain 99a5730
change to warning
tarang-jain a077406
style
tarang-jain d659875
add init_size param
tarang-jain ec2e8b7
Merge branch 'main' into combine-batch
tarang-jain 03a6473
docs
tarang-jain 42a8d9d
Merge branch 'combine-batch' of https://github.com/tarang-jain/cuvs i…
tarang-jain 86af2fa
rm direct cuda api calls
tarang-jain d4e4e2c
std::swap instead of raft::copy
tarang-jain 0819af5
cache batch norms
tarang-jain e0f079c
centroid norms can also be cached per iteration
tarang-jain c2f7390
mg n_iter
tarang-jain b9c3102
pre-commit
tarang-jain e3956c1
do not break c abi
tarang-jain 986d78a
Merge branch 'main' into combine-batch
tarang-jain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably shouldn't be modifying the wording here. And we probably want to use a different struct that breaks ABI, suffixed by the version (26.06).