Fix optional seed assignment in spectral embedding #1655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
Member
|
Isn't |
The spectral_embedding_config.seed is std::optional<uint64_t> but config.seed is uint64_t. This fix checks if the optional has a value before assigning it, preventing implicit conversion issues.
cjnolet
added
improvement
cjnolet
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
cjnolet
approved these changes
Jan 6, 2026
Contributor
Author
|
This is no longer needed. @aamijar changed the type in rapidsai/raft@f4a331e. |
github-project-automation
bot
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes optional seed assignment in
spectral_embedding.cuh.The
spectral_embedding_config.seedisstd::optional<uint64_t>butconfig.seedisuint64_t. This fix checks if the optional has a value before assigning it.