Conversation
tfeher
left a comment
There was a problem hiding this comment.
Thanks Julian for fixing this, LGTM!
|
@tfeher this is a breaking change, and it's also missing an update to the C API default. |
divyegala
left a comment
There was a problem hiding this comment.
Instead of a segmentation fault, can you put an error checker to fail gracefully if user tries to search a NONE hierarchy HNSW index?
I have changed the C API default as well.
Sorry to not me more specific. Our internal search works but a separate search with Hnswlib fails. Changing the default would enable the interoperability out of the box. |
Thanks @divyegala for catching my mistake. Indeed, users might be relying on the default value, so this is a breaking change. I have updated the labels. |
13e735d to
5cf9913
Compare
Change the default HNSW hierarchy from
NONEtoGPUto enable search with Hnswlib. Searching an HNSW index built withHnswHierarchy::NONEusing Hnswlib fails with a segmentation fault. This change should go into 25.12 to prevent such issues and improve the interoperability between cuVS and Hnswlib.