Update LDAP fingerprints for Windows#630
Open
gustavoluvizotto wants to merge 1 commit intorapid7:mainfrom
Open
Update LDAP fingerprints for Windows#630gustavoluvizotto wants to merge 1 commit intorapid7:mainfrom
gustavoluvizotto wants to merge 1 commit intorapid7:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that Windows AD instances could reply with the domainControllerFunctionality attribute before or after the OID from the supportedCapabilities attribute that determines it as ADC or LDS. I fixed the Windows fingerprints to allow the identification of such servers.
Motivation and Context
There is no current open issue related to the current change. I observed the behavior of a few instances of LDAP servers and updated their fingerprints.
How Has This Been Tested?
I tested manually against LDAP servers in my research. I could identify the servers as AD, whereas before, I identified them as Windows Server (without AD). However, the auto testers are not passing now. I added
sto the regex pattern(?im:of the fingerprints. For example:Rationale: I wrote a Golang application that uses the recog-go lib. Then, the Go regex indicates that
s"let . match \n", which is necessary. However, the ruby auto testers does not recognize such letter:Removing the
s, the issue disappears.Types of changes
Checklist: