[Backport 2.14.1] feat: add cpu model dropdown for harvester REK2 cluster provisioning#17161
Open
a110605 wants to merge 1 commit intorancher:release-2.14from
Open
[Backport 2.14.1] feat: add cpu model dropdown for harvester REK2 cluster provisioning#17161a110605 wants to merge 1 commit intorancher:release-2.14from
a110605 wants to merge 1 commit intorancher:release-2.14from
Conversation
Signed-off-by: Andy Lee <[email protected]>
a110605
changed the title
a110605
changed the title
richard-cox
requested changes
Apr 8, 2026
Member
richard-cox
left a comment
richard-cox
left a comment
There was a problem hiding this comment.
Would you be able to fill in the template?
Would you also be able to provide the contents of that harvester-system/node-cpu-model-configuration configmap (saves me upgrading my local harvester)?
|
|
||
| const modelEntries = Object.entries(cpuModelsData.models || {}); | ||
|
|
||
| modelEntries.sort((a, b) => a[0].localeCompare(b[0])); |
Member
There was a problem hiding this comment.
how come we sort modelEntries but not globalModels?
| networks: this.$store.dispatch('cluster/request', { url: `${ url }/k8s.cni.cncf.io.network-attachment-definitions` }), | ||
| storageClass: this.$store.dispatch('cluster/request', { url: `${ url }/${ STORAGE_CLASS }es` }), | ||
| settings: this.$store.dispatch('cluster/request', { url: `${ url }/${ MANAGEMENT.SETTING }s` }), | ||
| cpuModelConfig: this.$store.dispatch('cluster/request', { url: `${ url }/${ CONFIG_MAP }s/harvester-system/node-cpu-model-configuration` }), |
Member
There was a problem hiding this comment.
if server-side pagination for config maps is ...
- disabled - we're already fetching all config maps
- enabled - we're fetching specific config maps, this one can just be added to that list
so in both cases we can avoid this request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16724
Occurred changes and/or fixed issues
backport #17041 to release-2.14
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Add CPU Model dropdown in harvester RKE2 provisioning create page
The VM created on harvester
Checklist
Admin,Standard UserandUser Base