Add graceful shutdown for SSE streams#261
Merged
rsamoilov merged 1 commit intorage-rb:mainfrom Apr 5, 2026
Merged
Conversation
Use Iodine.task_inc!/task_dec! in SSE stream fibers so the server waits for in-progress streams to finish on restart, matching the existing behavior of Rage::Deferred tasks. Closes rage-rb#260
Contributor
Author
Thanks for quick merge! |
anuj-pal27
pushed a commit
to anuj-pal27/rage
that referenced
this pull request
Apr 5, 2026
Use Iodine.task_inc!/task_dec! in SSE stream fibers so the server waits for in-progress streams to finish on restart, matching the existing behavior of Rage::Deferred tasks. Closes rage-rb#260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSE streams currently get interrupted immediately on server restart. Deferred tasks already handle this with
Iodine.task_inc!/task_dec!to signal in-flight work, but SSE streams don't use the same mechanism.This adds the same
task_inc!/task_dec!calls toSSE::Application#start_stream. The server will now wait up to 15 seconds for active streams to finish before forcing shutdown, matching the existing deferred task behavior.The
ensureblock guaranteestask_dec!runs even if the stream raises an exception.Closes #260
This PR was authored by a human with AI coding assistance.