System Command component: Add terminal emulator field#1646
Merged
ra3xdh merged 1 commit intora3xdh:currentfrom Apr 27, 2026
Merged
System Command component: Add terminal emulator field#1646ra3xdh merged 1 commit intora3xdh:currentfrom
ra3xdh merged 1 commit intora3xdh:currentfrom
Conversation
On Linux, when a system command component is used, Qucs-S searches a hardcoded list of terminal emulators and use the first one available. It may happen that none of them is actually installed. This commit adds a new property field to specify which terminal emulator to use. If left blank, Qucs-S falls back to trying the hardcoded list, as before. Added qterminal (shipped with Lubuntu) and ptyxis (Fedora)
Owner
|
Thanks for finding this. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, when a system command component is used, Qucs-S searches a hardcoded list of terminal emulators and uses the first one available [1]. In Lubuntu and Fedora, this fails because the terminal emulator shipped with those distros are not in the list:
This PR adds a new property field to specify which terminal emulator to use. If left blank, Qucs-S falls back to trying the hardcoded list, as before.
Two terminal emulators were added to the default hardcoded search list:
[1] https://github.com/ra3xdh/qucs_s/blob/current/qucs/qucs.cpp#L4048