Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Copyingsection separator so index-related helpers are grouped together for clearer code organization.indexaccessors and ensureset_index/reset_indexare contiguous and behave consistently withSpectraFramecopy semantics.__getattr__special-case forindexnow that anindexproperty is present.Description
# Copyingseparator to appear after the index helper methods and correct the section header to# Index.indexproperty and setter, and keepset_indexandreset_indeximplementations that return newSpectraFrameobjects and ignoreinplace.__getattr__clause that returnedself.data.indexfor theindexattribute since the property now covers that behavior.tests/test_spectra.pyto coverindexsetter behavior andset_index/reset_indexmethods and adjusttest_getattrexpectations.Testing
tests/test_spectra.pybut were not run in this rollout.Codex Task