Open
Conversation
|
I'd prefer getting rid of the qurator namespace instead - e.g. just using "sbb_images", not "qurator.sbb_images" here. There really is no benefit in sharing the namespace, just problems. |
Author
IIUC these problems will be gone for good with the new-style namespace packaging. (But don't hold my feet to the fire for it.) A pro argument is: under the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current legacy approach to namespace packaging does not work with development/editable installation. See OCR-D/ocrd_all#433
This PR fixes it for this package – analogous PRs to the other qurator repos will follow.