Skip to content

Dcs 269 update to ua 1.6.5#10

Open
parasxos wants to merge 3 commits intomasterfrom
DCS-269_update_to_ua_1.6.5
Open

Dcs 269 update to ua 1.6.5#10
parasxos wants to merge 3 commits intomasterfrom
DCS-269_update_to_ua_1.6.5

Conversation

@parasxos
Copy link
Copy Markdown
Contributor

No description provided.

@parasxos parasxos requested a review from a team February 26, 2026 09:39
@parasxos
Copy link
Copy Markdown
Contributor Author

Looks good overall — the SDK renames are clean and complete.

One thing I noticed: in designToClassBody.jinja the Exceptions::BadStatusCode references were changed from unqualified to UaoClient:: hardcoded. Since the template supports --namespace, would it make sense to use {{namespace}}::Exceptions::BadStatusCode instead? That way it stays consistent if someone ever uses a different namespace. The unqualified form also worked before since the code is already inside the namespace block, so either way works — just not hardcoded.

@jsouter
Copy link
Copy Markdown

jsouter commented Feb 26, 2026

I think that makes sense, I will test that. I also had to change cut the namespace part from #include {{namespace}}ArrayTools.h, I'm not sure if that part was working previously or not.

@parasxos
Copy link
Copy Markdown
Contributor Author

Yes, the {{namespace}} prefix on the includes was already broken on master — the actual files are ArrayTools.h and UaoExceptions.h, there were never namespace-prefixed versions. So dropping the prefix is the right fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants