Conversation
|
Looks good overall — the SDK renames are clean and complete. One thing I noticed: in designToClassBody.jinja the Exceptions::BadStatusCode references were changed from unqualified to UaoClient:: hardcoded. Since the template supports --namespace, would it make sense to use {{namespace}}::Exceptions::BadStatusCode instead? That way it stays consistent if someone ever uses a different namespace. The unqualified form also worked before since the code is already inside the namespace block, so either way works — just not hardcoded. |
|
I think that makes sense, I will test that. I also had to change cut the namespace part from |
|
Yes, the {{namespace}} prefix on the includes was already broken on master — the actual files are ArrayTools.h and UaoExceptions.h, there were never namespace-prefixed versions. So dropping the prefix is the right fix. |
No description provided.