[deps] Pandoc 3.8.3, typst 0.14.2 #13249
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
@tarleb It seems that there's a |
|
Sorry, I hadn't seen this. I'll try to be there today. |
|
@tarleb suggests |
On further thought, this only works if we know that the replacement for the shortcode is in a position where this escaping is required. In order to do that, we would have to enrich the LPEG parser to learn about parsing links and images, and then to process shortcodes differently inside links and images. That's a pretty large undertaking. |
|
I've pushed a fix: page inset needs to be typst raw inline. Most of the other failures seem to be because we need to update the Typst templates from Pandoc to get Skylighting support. Not trivial as there's a bunch of new stuff, but not that bad. |
|
Importing So all the stuff I need to update (merging Chris Kenny's improvements with brand yaml, basically) is not reflected in tests. TL;DR We've been applying Now syntax highlighting will match by default! Claude's explanation:Quarto always sets highlight-style for ALL formats, including typst:
Before pandoc 3.8/3.9: This didn't matter because pandoc ignored the highlight-style for typst and used typst's native highlighting. After pandoc 3.8/3.9: Pandoc now respects --syntax-highlighting for typst output, so quarto's default "arrow" style triggers skylighting for ALL code blocks, including unlanguaged ones (wrapped in NormalTok). What is
|
|
Thanks @gordonwoodhull! What I mentioned yesterday is also that Pandoc now uses
So I think we need to check if we use that flag, and probably anticipate the end of deprecation warning in our default file use.
The new option is now Currently we use And maybe in other places. Should we do this in another PR maybe ? It is kind of part of the pandoc update though. |
|
I am just updating to benefit from new condensed logging |
|
I think the biggest cause of failures right now if from a LaTeX change in how table counters work in the Pandoc writer and templates. I still don't understand how to avoid that problem. |
|
Oh, I have dealt with that recently for the rticles R package. I needed to add the missing template part to the rticles' built-in template (rstudio/rticles#596) They do something in the Writer that expects something in the template. It could be either this template addition, or some adaptation in the way we create the table. Also related, this change in Pandoc is for ensuring that unlabelled tables don't increment counter. I remember this was a problem in cross ref with counter workaround to decrement or something, so it could be now conflicting with what Pandoc is doing. Hope it helps understand. (Disclaimer: I did not look at failing examples, just what I looked for my rticles maintainance about this) |
The functions in engine-shared.ts (languagesInMarkdown, languagesInMarkdownFile, postProcessRestorePreservedHtml) have identical implementations in src/core/pandoc/pandoc-partition.ts and src/core/jupyter/preserve.ts. Update imports to use the canonical locations and remove the duplicate file. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
for pandoc 3.8 next: investigate why this case enables syntax-highlighting
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
gordonwoodhull
force-pushed
the
deps/pandoc-2025-08
branch
from
257f39a to
a540401
Compare
|
Pushed the typst template updates. |
The unconditional disabling of table_attributes in 72452ee caused errors for formats like commonmark_x that don't support this extension. Pandoc 3.8.3+ validates all extension keys (both enabled and disabled) and rejects unsupported extensions. Use pandoc.format.all_extensions() to check if table_attributes is supported by the format before attempting to disable it.
|
Pushed fixes and tests to address #13857 (comment) We were still calling the Typst Thanks @mcanouil for reporting this! |
Align Quarto's article() function with Pandoc's October 2024 fix (commit e01023c1f) for Typst 0.12+ two-column layout compatibility. Changes: - Replace columns(cols, doc) wrapper with plain doc return (page.typ already sets columns via set page(columns:)) - Change title block wrapper from block() to place(top, float: true, scope: "parent", clearance: 4mm) so title/authors/abstract span both columns - Remove unused cols parameter from typst-show.typ This fixes the error "page configuration is not allowed inside of containers" that occurred when using landscape sections with two-column layouts, since columns() creates a container that prevents set page() directives inside it. Add smoke tests for two-column typst layouts that verify: - Page columns set via set page(columns:) not columns() function - Title block wrapped with place(scope: "parent") for column spanning - Integration with landscape sections - Integration with table of contents - Full title block (title, subtitle, authors, abstract, thanks) Co-Authored-By: Claude Opus 4.5 <[email protected]>
gordonwoodhull
force-pushed
the
deps/pandoc-2025-08
branch
from
f36f070 to
c5d6e82
Compare
Add tests.run.skip field to allow unconditional test skipping with custom message. Skip docusaurus equations test until Pandoc fix for display math newlines is released (fixed in pandoc@8123be6).
Pandoc 3.8+ wraps uncaptioned longtables with `{\def\LTcaptype{none}...}`
to prevent counter increment. When Quarto adds its own caption, this
definition conflicts with the caption package causing:
"Package caption Error: No float type 'none' defined."
Strip the LTcaptype definition while keeping the harmless { } wrapper.
- Skip test that are not relevant due to other failures - Add more verify steps to really check more than just noErrors
…oc fix Same issue as equations.qmd - Pandoc 3.7+ removes newlines in display math blocks. Fixed upstream in pandoc@8123be6, awaiting release.
The previous show rule used .map().join() which destroyed the list structure, breaking PDF/UA-1 validation. The new approach uses a nested show rule that modifies items in place while preserving the original terms element structure. Fix suggested by @mcanouil in: #13249 (comment) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
The last missing part took me time to understand as it was an issue thrown in JSS but it is related to I'll add some tests as this should have surfaced without extensions. Last thing before merging hopefully! |
|
To keep change in this PR small enough as this is a big one yet, I'll fix the root cause, and do the deprecation handling in another PR |
Pandoc 3.8 changed optSyntaxHighlighting from HighlightMethod type to Text. The old HighlightMethod FromJSON accepted null, but Text rejects it with: "Aeson exception: Error in $: parsing Text failed, expected String, but encountered Null" Pass "none" string instead of null when highlight-style: none is set.
The previous show rule used .map().join() which destroyed the list structure, breaking PDF/UA-1 validation. The new approach uses a nested show rule that modifies items in place while preserving the original terms element structure. Fix suggested by @mcanouil in: #13249 (comment) Co-Authored-By: Claude Opus 4.5 <[email protected]>
The previous show rule used .map().join() which destroyed the list structure, breaking PDF/UA-1 validation. The new approach uses a nested show rule that modifies items in place while preserving the original terms element structure. Fix suggested by @mcanouil in: #13249 (comment) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Brings: