[http-problem] Rename maven coordinates, java packages, examples#604
Conversation
|
@pazkooda if you have some time or spare tokens for a quick review - pls have a look. It does not have to be perfect from the get go, we need more changes and stabilization phase either way. |
|
Will try to look at it today early afternoon (CET) |
xstefank
left a comment
There was a problem hiding this comment.
Looks good, but can you please revert back the support for RESTEasy classic Jackson and JSON-B? We are still going to ship them also in Quarkus 4, and it would most likely break your extension users on 3.x right now.
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
I wasn't sure about this, but that's an excellent point, let me revert this back. |
| <artifactId>quarkus-resteasy-problem-deployment</artifactId> | ||
| <name>Quarkus - RESTeasy - Problem - Deployment</name> | ||
| <artifactId>quarkus-http-problem-deployment</artifactId> | ||
| <name>Quarkus - HTTP-Problem - Deployment</name> |
There was a problem hiding this comment.
Cosmetic: HTTP-Problem, we used REST ;)
There was a problem hiding this comment.
I think I've changed all places to HTTP-Problem and pushed it around the time you were reviewing this. And you commented the line where it's already updated. So let's clarify - which option are you suggesting again?
TLDRI believe we should go with the following:
WDYT @xstefank @pazkooda ? Once we're on the same page, I'll update the groupId (remove extra hyphen). Longer storyThis avoids implying ownership of a shared io.quarkiverse.http.* / quarkus.http.* family and stays consistent with Quarkiverse conventions (groupId as package-safe root; multi-word project suffix concatenated). For context, the old Similar examples in Quarkiverse:
|
|
@lwitkowski thanks, that is perfect. Let me know when I should take a look at this PR again! |
@xstefank I think I've applied all the changes I planned, so please have another look when you have time. Thanks! |
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
|
@pazkooda I'm merging this now, we can always change things later. I'd like to publish snapshot to Maven Central and play around with it. |
Native tests green!
Ref #480