Skip to content

Conversation

@mhucka
Copy link
Collaborator

@mhucka mhucka commented Nov 4, 2025

The warning described in #929 seems to be the result of using an older version of Eigen. Updating the version makes the warning go go away.

@github-actions github-actions bot added the size: S 10< lines changed <50 label Nov 4, 2025
@mhucka mhucka marked this pull request as ready for review November 4, 2025 01:41
@mhucka mhucka requested a review from sergeisakov November 4, 2025 01:42
@mhucka mhucka added area/health Involves general matters of project configuration, health, maintenance, and similar concerns area/c++ Involves the C++ code portions of qsim labels Nov 4, 2025
@mhucka mhucka changed the title Fix #929 by update Eigen to version 3.4.1 Fix #929 by updating Eigen to version 3.4.1 Nov 5, 2025
@github-actions github-actions bot added Size: XS <10 lines changed and removed size: S 10< lines changed <50 labels Jan 6, 2026
I'm not sure where I got the previous commit hash from, but this one now
is the right one for Eigen 3.4.1.

Source: https://gitlab.com/libeigen/eigen/-/releases/3.4.1
@github-actions github-actions bot added size: S 10< lines changed <50 and removed Size: XS <10 lines changed labels Jan 6, 2026
Apparently I had the wrong sha?
@mhucka mhucka added this pull request to the merge queue Jan 6, 2026
Merged via the queue into quantumlib:main with commit fca5a12 Jan 6, 2026
28 checks passed
@mhucka mhucka deleted the mh-update-eigen branch January 6, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/c++ Involves the C++ code portions of qsim area/health Involves general matters of project configuration, health, maintenance, and similar concerns size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants