[PropertyOverrideButton] fire modfiication signals on setToProperty#65921
[PropertyOverrideButton] fire modfiication signals on setToProperty#65921troopa81 wants to merge 1 commit intoqgis:masterfrom
Conversation
🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
@troopa81 this potentially introduces update loops (eg a widget listening to changed signals on the button, then an "update state" method in that widget setting the button GUI to match, which the triggers and unwanted "changed" signal from the widget (when nothing actually was changed by the user) It's usually cleaner to make the caller responsible for handling this, and not relying on API setting of button state to trigger a different slot. Just call that manually from the code setting the button state instead. Otherwise you'd need to do a full check over everywhere these signals are connected and setToProperty is called, to verify that there's no chance of regression. (And that's a LOT of places) |
Fixed during #64877
No AI usage