Open
Conversation
Contributor
🧮 Vcpkg update report🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Apr 15, 2026
Comment on lines
+268
to
+271
| // Separate thumbnail capture pass to save scaled-down images of the | ||
| // rendered view to aid in debugging (e.g., Tracy profiler frame images). | ||
| Qt3DRender::QRenderCapture *mThumbnailCapture = nullptr; | ||
| Qt3DRender::QTexture2D *mThumbnailTexture = nullptr; |
Collaborator
There was a problem hiding this comment.
these should be gated by #ifdef HAVE_TRACY -- otherwise they may trigger unused member warnings.
Contributor
Author
There was a problem hiding this comment.
The code that uses these is not gated behind `HAVE_TRACY``, only the call to initialise that part of the frame graph is, so no warnings should be triggered.
I could surround all the new code by ifdefs, but I think it's better like this, to make sure the code doesn't atrophy.
Assisted-By: Claude Opus 4.5
nyalldawson
approved these changes
Apr 15, 2026
2596dec to
3d426b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tracy is a popular debugging tool for (not only) 3D applications that combines sampled stacktraces with manually added information in a single interface. QGIS already has support for generating traces in Chromium trace event format via
QgsEventTracing, but Tracy is more capable, which should help us both find performance issues and debug intermittent 3D issues.This PR adds support for embedding a Tracy client inside QGIS, gated behind a CMake option
WITH_TRACY. I've re-used the existingQgsEventTracinginterface to forward any zones to Tracy, added new methods to send variables to be plotted, and also forwarded log messages, 3D frame begin events and thumbnails of rendered frames.Since I expect only some developers will use this integration, the build system currently expects Tracy to be already installed as a system package. Another option is to install Tracy via
vcpkg.AI tool usage