Skip to content

fix(point3dsymbol): make elevation relative to chunk origin#65714

Open
benoitdm-oslandia wants to merge 2 commits intoqgis:masterfrom
benoitdm-oslandia:fix/point3d_relative_elevation
Open

fix(point3dsymbol): make elevation relative to chunk origin#65714
benoitdm-oslandia wants to merge 2 commits intoqgis:masterfrom
benoitdm-oslandia:fix/point3d_relative_elevation

Conversation

@benoitdm-oslandia
Copy link
Copy Markdown
Collaborator

Elevation data are referenced according to 0 but X/Y coordinates are computed according to chunk center. This PR makes the chunk center reference common to all coordinates.

@benoitdm-oslandia benoitdm-oslandia self-assigned this Apr 7, 2026
@benoitdm-oslandia benoitdm-oslandia added the 3D Relates to QGIS' 3D engine or rendering label Apr 7, 2026
@github-actions github-actions Bot added this to the 4.2.0 milestone Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 5984d5e)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This app is not notarized, run sudo xattr -d com.apple.quarantine /Applications/QGIS*.app to avoid the warning
(Built from commit 5984d5e)

@benoitdm-oslandia
Copy link
Copy Markdown
Collaborator Author

@ptitjano gentle ping!

@uclaros
Copy link
Copy Markdown
Contributor

uclaros commented Apr 8, 2026

Isn't mChunkOrigin.z() always zero for vector layers / annotation?

@nyalldawson
Copy link
Copy Markdown
Collaborator

Yeah -- I'd like to see some more instructions on how this manifests as a bug

@github-actions
Copy link
Copy Markdown
Contributor

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions Bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 23, 2026
@benoitdm-oslandia
Copy link
Copy Markdown
Collaborator Author

Hi! sorry for the delay! This is not a bug in the current state of the code but it is an issue for another PR I am working on (rework of #62676). So in the current state of the code, this PR add more consistency in the way we handle chunk origin in point3dsymbol.

@github-actions github-actions Bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3D Relates to QGIS' 3D engine or rendering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants