Skip to content

fix(expression): rename XXX_equals to equals_XXX#65674

Open
benoitdm-oslandia wants to merge 10 commits intoqgis:masterfrom
benoitdm-oslandia:feat/expression_geometry_backend
Open

fix(expression): rename XXX_equals to equals_XXX#65674
benoitdm-oslandia wants to merge 10 commits intoqgis:masterfrom
benoitdm-oslandia:feat/expression_geometry_backend

Conversation

@benoitdm-oslandia
Copy link
Copy Markdown
Collaborator

This PR follows #62603 and rename added functions:

  • exactly_equals -> equals_exact

  • fuzzy_equals -> equals_fuzzy

  • topologically_equals -> equals_topological

  • overlay_exactly_equals -> overlay_equals_exact

  • overlay_fuzzy_equals -> overlay_equals_fuzzy

  • overlay_topologically_equals -> overlay_equals_topological

cc @DelazJ @agiudiceandrea

@benoitdm-oslandia benoitdm-oslandia self-assigned this Apr 2, 2026
@github-actions github-actions Bot added this to the 4.2.0 milestone Apr 2, 2026
@github-actions github-actions Bot added the Expressions Related to the QGIS expression engine or specific expression functions label Apr 2, 2026
@benoitdm-oslandia
Copy link
Copy Markdown
Collaborator Author

hum... not the most fresh master :( ... I will rebase!

By the way, is it a problem if we use files with the '.json' extension for the files in resources/function_help/json/ ? The script process_function_template.py take any file to do its job and using '.json' files helps the IDE when editing its content.

@benoitdm-oslandia benoitdm-oslandia force-pushed the feat/expression_geometry_backend branch from f7ef52f to 51eafee Compare April 2, 2026 14:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This app is not notarized, run sudo xattr -d com.apple.quarantine /Applications/QGIS*.app to avoid the warning
(Built from commit 0362a2d)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 0362a2d)

@DelazJ
Copy link
Copy Markdown
Contributor

DelazJ commented Apr 2, 2026

Thanks @benoitdm-oslandia for the quick update.
I didn't know there was a template file for generating these help files.

Moreover I think an explanation of the differences between the way the backends work should be added / improved, and the examples provided in the functions description should show such differences.

generally speaking, ”QGIS vs GEOS” appears at different places in QGIS (digitizing, Processing, expressions) but the difference between them remains often obscure for most of our users (me included).
An issue, with the existing examples, is that the output is the same regardless of the used backend. An example returning true in one case, false in the other may hopefully give some hints to the user...

@benoitdm-oslandia
Copy link
Copy Markdown
Collaborator Author

@DelazJ Ok, I now understand! I will try to make it more clear

Comment thread resources/function_help/json/equals_fuzzy.json Outdated
Comment thread resources/function_help/json/equals_exact.json Outdated
Comment thread resources/function_help/json/equals_topological.json Outdated
Comment thread resources/function_help/json/equals_topological.json
Comment thread resources/function_help/json/equals_topological.json Outdated
Comment thread resources/function_help/json/overlay_equals_fuzzy.json Outdated
Comment thread resources/function_help/json/overlay_equals_exact.json Outdated
Comment thread resources/function_help/json/overlay_equals_topological.json Outdated
Comment thread resources/function_help/json/overlay_equals_topological.json
Comment thread src/core/expression/qgsexpressionfunction.cpp Outdated
@benoitdm-oslandia
Copy link
Copy Markdown
Collaborator Author

@DelazJ @agiudiceandrea make documentation and test changes

@benoitdm-oslandia
Copy link
Copy Markdown
Collaborator Author

@DelazJ @agiudiceandrea gentle ping

@agiudiceandrea
Copy link
Copy Markdown
Member

Thanks for the PR. I'm not able to have a look at it in these days. I'll add a comment in the next days.

Copy link
Copy Markdown
Contributor

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @benoitdm-oslandia
I made a partial review, considering that some comments may apply to the "friend function".

Comment thread resources/function_help/json/equals_exact.json Outdated
Comment thread resources/function_help/json/equals_fuzzy.json Outdated
Comment thread resources/function_help/json/equals_fuzzy.json Outdated
Comment thread resources/function_help/json/equals_topological.json Outdated
Comment thread resources/function_help/json/equals_topological.json Outdated
Comment thread resources/function_help/json/equals_topological.json Outdated
Comment thread resources/function_help/json/equals_topological.json
Comment thread resources/function_help/json/equals Outdated
Comment thread resources/function_help/json/equals_exact.json Outdated
Comment thread tests/src/core/geometry/testqgsgeometry.cpp
@benoitdm-oslandia benoitdm-oslandia force-pushed the feat/expression_geometry_backend branch from 77c37cd to 83db5f5 Compare April 22, 2026 07:41
@benoitdm-oslandia
Copy link
Copy Markdown
Collaborator Author

rebase and updates from review

@benoitdm-oslandia
Copy link
Copy Markdown
Collaborator Author

@uclaros is everything ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expressions Related to the QGIS expression engine or specific expression functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants