Add fsspec support to msi_safe reader#3306
Open
simonreise wants to merge 2 commits intopytroll:mainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3306 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 463 463
Lines 58870 58871 +1
=======================================
+ Hits 56711 56712 +1
Misses 2159 2159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 19579904993Details
💛 - Coveralls |
Member
|
FYI, the Sentinel-2 file format will be changing next year to Zarr - so if this PR is problematic for you then I'd recommend considering how much time you're willing to spend on something that'll be obselete in 6 months :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes added in this PR are nearly identical to #3173
Zip archives are still the default distribution format for Sentinel-2 MSI_SAFE imagery, however, now SatPy
msi_safereader does not support it.fsspeccan be used to read data from archives, or, e.g. remote data sources like AWS or Planetary Computer.The msi_safe reader file reading functionality is nearly identical to the one of Landsat readers, so I tried to implement fsspec support the same way.
However, I am stuck on adding tests, because in the current testing workflow no files are being used. For
XMLfiles theStringIOandBytesIOobjects are being used (however, we can write the content of these objects to files in the fsspec filesystem to test if it works). Forjp2files no reading is performed at all, instead of actual reading the function is just being mocked bymock.path, which returns the pre-defined fake data instead of loading something from file (so, we either have to just leave it as-is or add actual loading functionality to the tests).AUTHORS.mdif not there already