fix: reject repositories.<name>.url in config#10846
Closed
lawrence3699 wants to merge 1 commit intopython-poetry:mainfrom
Closed
fix: reject repositories.<name>.url in config#10846lawrence3699 wants to merge 1 commit intopython-poetry:mainfrom
lawrence3699 wants to merge 1 commit intopython-poetry:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10570.
Before
poetry config repositories.repo2.url https://...is accepted even though the documented CLI syntax ispoetry config repositories.<name> <url>.That writes a nested
[repositories.repo2.url]table toconfig.toml, which then makes commands such aspoetry config --listfail withunhashable type: 'dict'.After
Reject
repositories.<name>.urlwhen setting repository URLs and point users to the documentedrepositories.<name>form instead.This keeps the existing
repositories.<name>.urlread path intact while preventing the bad write that corrupts the config structure.Validation
.venv/bin/pytest tests/console/commands/test_config.py -qPOETRY_CONFIG_DIR=$(mktemp -d)poetry config repositories.repo2.url https://...corruptedconfig.tomlandpoetry config --listfailedpoetry config --listsucceeds