tests: make test independent of system pythons#10817
Merged
radoering merged 1 commit intopython-poetry:mainfrom Apr 3, 2026
Merged
tests: make test independent of system pythons#10817radoering merged 1 commit intopython-poetry:mainfrom
radoering merged 1 commit intopython-poetry:mainfrom
Conversation
The column width of the output may vary depending on the available system pythons.
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The inline loop that manually registers poetry-managed interpreters in
test_list_poetry_managedis fairly verbose and duplicates knowledge about the directory structure and flags; consider extracting a small helper fixture or function to encapsulate this setup so the test focuses on behavior rather than filesystem details. - You now build
expected_systemandexpected_poetrysets directly from hard-coded strings; if the output formatting changes (e.g., column widths or labels), these assertions may become brittle—consider deriving expected lines from the same parameters used for registration (versions, implementations, paths) or using a looser comparison that validates the key fields without depending on spacing.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The inline loop that manually registers poetry-managed interpreters in `test_list_poetry_managed` is fairly verbose and duplicates knowledge about the directory structure and flags; consider extracting a small helper fixture or function to encapsulate this setup so the test focuses on behavior rather than filesystem details.
- You now build `expected_system` and `expected_poetry` sets directly from hard-coded strings; if the output formatting changes (e.g., column widths or labels), these assertions may become brittle—consider deriving expected lines from the same parameters used for registration (versions, implementations, paths) or using a looser comparison that validates the key fields without depending on spacing.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The column width of the output may vary depending on the available system pythons.
Pull Request Check List
Resolves: #10796