Limit the length of the donated hardware name#142
Merged
wookie184 merged 2 commits intopython-discord:mainfrom Apr 1, 2025
Merged
Limit the length of the donated hardware name#142wookie184 merged 2 commits intopython-discord:mainfrom
wookie184 merged 2 commits intopython-discord:mainfrom
Conversation
janine9vn
approved these changes
Apr 1, 2025
Contributor
|
The original name is still mentioned in the message, so this isn't enough, no? |
Member
Author
|
Oh yeah... maybe it's better to just give an error response in that case |
janine9vn
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Message example: https://discord.com/channels/267624335836053506/1356544424619806781/1356631764998553652
The
improve_gpu_namefunction can increase the length of a string, creating a GPU name that will cause thectx.replycall to fail.