-
-
Notifications
You must be signed in to change notification settings - Fork 256
Fix trashcan delete reaction in DMs #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix trashcan delete reaction in DMs #1713
Conversation
|
As it stands currently, considering you have both |
Yes, I just tested that, and I think on_reaction_add should be removed then. Also the try-except block removed previously for deleted reactions needs to be added again for this change, which I have done. Few imports also became unused after this change so removing them as well. |
…ChannelType.private
Relevant Issues
Closes #1450
Description
Added on_raw_reaction_add handler to support reaction events in DMs, as the standard on_reaction_add doesn't fire in DM contexts.
Original Implementation @ OSCxSST/sir-lancebot-SLB/pull/20
I Did: