fix: Pass mmcore instance to StageWidget children#102
Merged
tlambert03 merged 5 commits intopymmcore-plus:mainfrom Aug 19, 2025
Merged
fix: Pass mmcore instance to StageWidget children#102tlambert03 merged 5 commits intopymmcore-plus:mainfrom
tlambert03 merged 5 commits intopymmcore-plus:mainfrom
Conversation
gselzer
changed the title
tlambert03
reviewed
Aug 19, 2025
tests/test_main_window.py
Outdated
| yield gui | ||
|
|
||
|
|
||
| def test_main_window_with_existing_core(qtbot: QtBot, qapp: QApplication) -> None: |
Member
There was a problem hiding this comment.
would this test actually have caught this error? we don't actually instantiate much inside the initial of the main window... this test feels vaguely related by not quite that useful. if you agree, go ahead and remove this test and we can merge without the test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary to work with non-
CMMCorePlusobjects passed as the core object (e.g. aClientCMMCorePlusfrompymmcore-remote)